BES-1248: Post build logs to aws for docker builds #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndp-opendap
requested changes
Feb 3, 2026
Contributor
ndp-opendap
left a comment
ndp-opendap
left a comment
There was a problem hiding this comment.
Sure that works!
My two bits (for the floor, as you wish): I have come around to James' preference of explicitly calling test rather than doing it implicitly with the [[...]] syntax:
if test "$BES_BUILD" = "main" -o "$BES_BUILD" = "distcheck" -o "$BES_BUILD" = "docker"*
travis/upload-test-results.sh
Outdated
|
|
||
| LOG_FILE_TGZ=bes-autotest-${TRAVIS_JOB_NUMBER}-logs.tar.gz | ||
| if test x$BES_BUILD = xmain -o x$BES_BUILD = xdistcheck | ||
| if [[ $BES_BUILD = "main" || "$BES_BUILD" = "distcheck" || "$BES_BUILD" = "docker"* ]] |
Contributor
There was a problem hiding this comment.
First $BES_BUILD needs double quotes
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature #1248. Adds parity with other jobs, namely, job log is now posted to AWS for docker jobs.
Tasks
Tests added/updatedDead code removed